feat: initial setup of the kubernetes extension - #1
Merged
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
matzew
reviewed
Jan 20, 2026
| err = wait.PollUntilContextTimeout(ctx, time.Second, timeout, true, func(ctx context.Context) (bool, error) { | ||
| obj, getErr := e.client.Get(ctx, gvr, ref.name, ref.namespace) | ||
| if getErr != nil { | ||
| return false, nil // Keep polling on transient errors |
Contributor
There was a problem hiding this comment.
we want to differentiate on things like IsNotFound ? Or is that good for now?
matzew
reviewed
Jan 20, 2026
|
|
||
| timeoutStr, _ := args["timeout"].(string) | ||
| if timeoutStr == "" { | ||
| timeoutStr = "60s" |
Contributor
There was a problem hiding this comment.
could be a constant, since the operation also says that default is 60
Contributor
|
Generally LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: I will add a README with usage instructions after verifying the release process works and is compatible with the github extension references in gevals core